Merge pull request #94 from LUSHDigital/feat/remove-path-from-metrics

Feat/remove path from metrics
LUSHDigital · Mar 20, 2020 · f6ad56b · f6ad56b
2 parents a6a7ab8 + 48fa26d
commit f6ad56b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/middleware/metricsmw/README.md b/middleware/metricsmw/README.md
@@ -28,7 +28,7 @@ Using gorilla mux.
 
 ```go
 r := mux.NewRouter()
-r.Use(metrics.MeasureRequestsMiddleware)
+r.Use(mux.MiddlewareFunc(metrics.MeasureRequestsMiddleware))
 ```
 
 Using standard net/http library.

diff --git a/middleware/metricsmw/http.go b/middleware/metricsmw/http.go
@@ -17,7 +17,7 @@ var (
 			Name: "http_request_duration_seconds",
 			Help: "Duration in seconds of each request",
 		},
-		[]string{"method", "code", "path"},
+		[]string{"method", "code"},
 	)
 
 	// ResponseSizeHistogram measures the size in bytes for responses.
@@ -26,7 +26,7 @@ var (
 			Name: "http_response_byte_size",
 			Help: "Size in bytes of each response",
 		},
-		[]string{"method", "code", "path"},
+		[]string{"method", "code"},
 	)
 
 	// All represents a combination of all HTTP metric collectors.
@@ -103,7 +103,6 @@ func MeasureRequests(next http.HandlerFunc) http.HandlerFunc {
 		labels := prometheus.Labels{
 			"method": r.Method,
 			"code":   strconv.Itoa(rec.status),
-			"path":   r.RequestURI,
 		}
 
 		if rsh, err := ResponseSizeHistogram.GetMetricWith(labels); err != nil {