Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plonky2 for plonky2-bn254-pairing #1

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

silathdiir
Copy link
Collaborator

@silathdiir silathdiir commented Sep 3, 2024

Need to merge below PRs first:
Lagrange-Labs/plonky2#10
Lagrange-Labs/plonky2-ecdsa#3
Lagrange-Labs/plonky2-bn254#7

The test_multi_miller_loop_target in plonky2-bn254-pairing which is related with pairing (and other tests) could pass.

@silathdiir silathdiir changed the title [don't-merge] fix: update plonky2 for plonky2-bn254-pairing fix: update plonky2 for plonky2-bn254-pairing Sep 4, 2024
@silathdiir silathdiir marked this pull request as draft September 5, 2024 02:55
@silathdiir silathdiir changed the title fix: update plonky2 for plonky2-bn254-pairing [WIP] fix: update plonky2 for plonky2-bn254-pairing Sep 5, 2024
@silathdiir silathdiir changed the title [WIP] fix: update plonky2 for plonky2-bn254-pairing fix: update plonky2 for plonky2-bn254-pairing Sep 5, 2024
@silathdiir silathdiir marked this pull request as ready for review September 5, 2024 03:32
Copy link

@nikkolasg nikkolasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i'll be honest I don't really have the mental space to go deep in this PR so if the test passes that's what matters.

@silathdiir silathdiir merged commit 51b17a4 into main Sep 6, 2024
1 check passed
@silathdiir silathdiir deleted the update-plonky2 branch September 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants