Fix type hint for func argument to inject #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Nov 8, 2024
| @@ -48,7 +48,7 @@ def __call__( | |||
|
|
|||
| @overload | |||
| def inject( # pragma: no cover | |||
| func: None, | |||
| func: None = None, | |||
There was a problem hiding this comment.
I also think it would also be reasonable to just drop this argument completely from this overload:
Suggested change
| func: None = None, |
but with the current approach in the PR, you at least have the option to purposely use func=None as an argument if desirable for some exotic reason..
There was a problem hiding this comment.
Yes, indeed, but I think, that it should be Literal[None] = None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, making this change has no impact on the runtime behavior, and doesn't cause any code that currently passes type-checking to fail. However, it makes it so that doing, e.g.:
doesn't produce a type error.