📦 NEW: Config based env #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import pipeSummary from '../baseai/pipes/summary'; | ||
| import {Pipe} from './../../../packages/core/src/pipes/pipes'; |
There was a problem hiding this comment.
This should be imported from core. This will break.
There was a problem hiding this comment.
Replace it with
import {Pipe} from '@baseai/core';
packages/baseai/types/config.ts
Outdated
| @@ -29,4 +29,16 @@ export interface BaseAIConfig { | |||
| log: LoggerConfig; | |||
| memory: MemoryConfig; | |||
| envFilePath: string; | |||
| env: { | |||
There was a problem hiding this comment.
This should be optional
| // Other default configuration options can be added here | ||
| env: {} as any |
There was a problem hiding this comment.
We should not add it to default config as it is optional.
ahmadawais
force-pushed
the
aa/config-env
branch
from
f7f6375
to
17c0dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config file based env vars to support Cloudflare and other envs where
process.envis not available.