Fix single node tree verification bug #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
litt3
commented
Dec 18, 2024
litt3
commented
- Remove the incorrect invariant check, which would fail proof with 0 length
- Add unit test to confirm 0 length proofs can succeed verification
- closes Inclusion proof verification doesn't permit trees consisting of a single node #215
samlaf
reviewed
Dec 18, 2024
samlaf
approved these changes
Dec 19, 2024
epociask
approved these changes
Dec 20, 2024
| @@ -7,9 +7,18 @@ import ( | |||
| "github.com/ethereum/go-ethereum/crypto" | |||
| ) | |||
|
|
|||
| // ProcessInclusionProof processes the Merkle root proof | |||
| // ProcessInclusionProof computes the merkle root hash based on the provided leaf and proof, returning the result. | |||
There was a problem hiding this comment.
knit - should we link the on-chain method we're referencing?
There was a problem hiding this comment.
Nice! Agree everytime we are mimicking onchain logic (which we should minimize and make eth_calls instead when applicable / not latency sensitive), we def need to add this as comment, because its a VERY important invariant that needs to be maintained.
Signed-off-by: litt3 <[email protected]>
Signed-off-by: litt3 <[email protected]>
samlaf
force-pushed
the
permit-single-node-tree
branch
from
6357d45 to
b412bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.