Skip to content

Commit

Permalink
Fix PR comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Siddharth More authored and Siddharth More committed Apr 24, 2024
1 parent 1c0dd7c commit 64e1904
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/docker-publish-opr-node-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ on:
version:
description: 'Version (Required)'
required: true
gitCommit:
description: 'GitCommit (Required)'
required: true
gitDate:
description: 'GitDate (Required)'
required: true
release_tag:
description: 'Release Tag (Optional)'
required: false
Expand Down Expand Up @@ -67,7 +73,7 @@ jobs:
tags: ${{ env.REGISTRY }}/layr-labs/eigenda/opr-node:${{ steps.set_tag.outputs.tag }}
cache-from: type=local,src=/tmp/.buildx-cache
cache-to: type=local,dest=/tmp/.buildx-cache-new
build-args: SEMVER=${{ github.event.inputs.version }}
build-args: SEMVER=${{ github.event.inputs.version }},GITCOMMIT=${{ github.event.inputs.gitcommit }},DATE=${{ github.event.inputs.GitDate }}
if: ${{ success() }}

- name: Build and Push NodePlugin Image
Expand Down
4 changes: 3 additions & 1 deletion node/cmd/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
FROM golang:1.21.1-alpine3.18 as builder

ARG SEMVER
ARG GITCOMMIT
ARG GITDATE

RUN apk add --no-cache make musl-dev linux-headers gcc git jq bash

Expand All @@ -18,7 +20,7 @@ COPY go.sum /app

WORKDIR /app/node

RUN go build -ldflags="-X 'node.SemVer=${SEMVER}'" -o ./bin/node ./cmd
RUN go build -ldflags="-X 'node.SemVer=${SEMVER}' -X 'node.GitCommit=${GITCOMMIT}' -X 'node.GitDate=${GITDATE}'" -o ./bin/node ./cmd

FROM alpine:3.18

Expand Down
6 changes: 3 additions & 3 deletions node/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ const (
// Min number of seconds for the ExpirationPollIntervalSecFlag.
minExpirationPollIntervalSec = 3
AppName = "da-node"
GitCommit = ""
GitDate = ""
)

var (
Expand All @@ -34,7 +32,9 @@ var (
0: "eth_quorum",
1: "permissioned_quorum",
}
SemVer = "v0.0.0"
SemVer = "v0.0.0"
GitCommit = ""
GitDate = ""
)

// Config contains all of the configuration information for a DA node.
Expand Down

0 comments on commit 64e1904

Please sign in to comment.