Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refreshOnchainPaymentState arg #1012

Merged
merged 1 commit into from
Dec 17, 2024
Merged

refactor: refreshOnchainPaymentState arg #1012

merged 1 commit into from
Dec 17, 2024

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 17, 2024

Why are these changes needed?

Function RefreshOnchainPaymentState doesn't need a eth reader passed in as paymentChainState already has an eth client

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/onchain-payment-state-fix branch from f4c4bb0 to f5db445 Compare December 17, 2024 00:22
@hopeyen hopeyen requested a review from ian-shim December 17, 2024 00:44
@hopeyen hopeyen merged commit 95488ff into master Dec 17, 2024
9 checks passed
@hopeyen hopeyen deleted the hope/onchain-payment-state-fix branch December 17, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @ian-shim