Fail v2 blobs for no attestations #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
reviewed
Dec 19, 2024
| } | ||
|
|
||
| if failed { | ||
| err := d.blobMetadataStore.UpdateBlobStatus(ctx, blobKey, v2.INSUFFICIENT_SIGNATURES) |
There was a problem hiding this comment.
So right now the insufficient signature state is for when a quorum has no attestations? Would we ever use that state for doing something like a quorum only recieved X% signatures?
There was a problem hiding this comment.
Yeah
We can improve this by either considering the coding rate or the default confirmation threshold onchain, but this is a quick fix before further steps
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
|
|
ian-shim
force-pushed
the
fail-blobs-if-no-attestation
branch
2 times, most recently
from
3739bfb to
f981ee4
Compare
dmanc
approved these changes
Dec 19, 2024
ian-shim
force-pushed
the
fail-blobs-if-no-attestation
branch
from
f981ee4 to
8b28e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If a blob receives no attestation for any of its target quorums, update status as
INSUFFICIENT_SIGNATURESChecks