[encodingstreamer] Validate quorums #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Dec 6, 2023
| @@ -184,7 +184,7 @@ func (c *churner) getOperatorsToChurn(ctx context.Context, quorumIDs []uint8, op | |||
| return nil, errors.New("maxOperatorCount is 0") | |||
| } | |||
|
|
|||
| if uint32(len(operatorStakes[i])) < operatorSetParams.MaxOperatorCount { | |||
There was a problem hiding this comment.
possibly a bug in previous implementation.
operatorStakes should be indexed by quorum ID instead of index of quorumIDs
ian-shim
commented
Dec 6, 2023
| @@ -26,6 +26,8 @@ type OperatorSetParam struct { | |||
| ChurnBIPsOfTotalStake uint16 | |||
| } | |||
|
|
|||
| type OperatorStakes map[QuorumID]map[OperatorIndex]OperatorStake | |||
There was a problem hiding this comment.
Replaced existing use of [][]OperatorStake with this new type as it's more clear how OperaterStake are indexed
ian-shim
force-pushed
the
encoding-streamer-validate-quorums
branch
from
4bd4da3 to
e785104
Compare
ian-shim
force-pushed
the
encoding-streamer-validate-quorums
branch
from
e785104 to
c109d78
Compare
mooselumph
reviewed
Jan 5, 2024
ian-shim
force-pushed
the
encoding-streamer-validate-quorums
branch
from
c109d78 to
5b597f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, quorum validation is delegated to the disperser server.
Encoding streamer does not handle invalid quorums, and if there's a request with invalid quorum, the entire iteration fails and encoding loop halts.
This PR addresses this by identifying invalid quorums and filtering out those blobs.
Checks