Updated assignments commitments #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
reviewed
Jan 4, 2024
There was a problem hiding this comment.
I think this also needs to be updated: https://github.com/Layr-Labs/eigenda/blob/master/test/synthetic-test/synthetic_client_test.go#L497
Good catch, should be fixed now! |
siddimore
reviewed
Jan 11, 2024
| quorums := make([]rollupbindings.IEigenDAServiceManagerQuorumBlobParam, len(blobHeader.GetBlobQuorumParams())) | ||
| for i, quorum := range blobHeader.GetBlobQuorumParams() { | ||
| quorums[i] = rollupbindings.IEigenDAServiceManagerQuorumBlobParam{ | ||
| QuorumNumber: uint8(quorum.GetQuorumNumber()), | ||
| AdversaryThresholdPercentage: uint8(quorum.GetAdversaryThresholdPercentage()), | ||
| QuorumThresholdPercentage: uint8(quorum.GetQuorumThresholdPercentage()), | ||
| QuantizationParameter: uint8(quorum.GetQuantizationParam()), | ||
| ChunkLength: quorum.GetChunkLength(), |
|
Synthetic Test client changes look good. PR changes overall LGTM |
jianoaix
reviewed
Jan 18, 2024
| @@ -95,10 +95,17 @@ contract MockRollupTest is BLSMockAVSDeployer { | |||
| //get commitment with illegal value | |||
| (IEigenDAServiceManager.BlobHeader memory blobHeader, EigenDABlobUtils.BlobVerificationProof memory blobVerificationProof) = _getCommitment(pseudoRandomNumber); | |||
|
|
|||
| IEigenDAServiceManager.QuorumBlobParam[] memory quorumBlobParamsCopy = new IEigenDAServiceManager.QuorumBlobParam[](2); | |||
There was a problem hiding this comment.
better not to hardcode it, i.e. create the array with blobHeader.quorumBlobParams.length instead of 2
| EigenDABlobUtils.verifyBlob(blobHeader, eigenDAServiceManager, blobVerificationProof); | ||
|
|
||
| // zero out the chunkLengths (this a temporary hack) | ||
| for (uint256 i = 0; i < blobHeader.quorumBlobParams.length; i++) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
blobHeaderHashto include theChunkLengthparameter for each quorum so that consensus onChunkLengthis enforced across nodes.EigenDAServiceManager.solandMockRollup.solChecks