Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update health check to use default implementation #149

Merged
merged 3 commits into from
Dec 27, 2023

Conversation

dmanc
Copy link
Contributor

@dmanc dmanc commented Dec 26, 2023

Why are these changes needed?

Use default health check implementation https://pkg.go.dev/google.golang.org/grpc/health

Tested with https://github.com/grpc-ecosystem/grpc-health-probe

grpc-health-probe -tls -addr=disperser.eigenda-preprod.eigenops.xyz:443 -service="disperser.Disperser" 
status: SERVING

grpc-health-probe -tls -addr=disperser.eigenda-preprod.eigenops.xyz:443 -service="aaa"       
error: health rpc failed: rpc error: code = NotFound desc = unknown service

grpc-health-probe -tls -addr=disperser.eigenda-preprod.eigenops.xyz:443 -service="disperser.Disperser"
error: health rpc failed: rpc error: code = Unavailable desc = unexpected HTTP status code received from server: 503 (Service Unavailable)

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@dmanc dmanc requested review from jianoaix and siddimore December 27, 2023 01:01
@dmanc dmanc marked this pull request as ready for review December 27, 2023 01:02
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@dmanc dmanc merged commit 071b933 into Layr-Labs:master Dec 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants