Allowlist with specified rate limits #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Jan 5, 2024
|
|
||
| // Get the encoded blob size from the blob header. Calculation is done in a way that nodes can replicate | ||
| blobSize := len(blob.Data) | ||
| length := core.GetBlobLength(uint(blobSize)) | ||
| encodedLength := core.GetEncodedBlobLength(length, uint8(blob.RequestHeader.SecurityParams[param.QuorumID].QuorumThreshold), uint8(blob.RequestHeader.SecurityParams[param.QuorumID].AdversaryThreshold)) |
There was a problem hiding this comment.
there's no guarantee that the security params are ordered by the quorum ID
mooselumph
approved these changes
Jan 5, 2024
ian-shim
force-pushed
the
allowlist-specify-throughput
branch
from
1dcbfeb to
b50a7d3
Compare
ian-shim
changed the title
ian-shim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Removes allowlist added in #122 in favor of one that specifies rate limits for each allowlisted IP.
Checks