Update accounting logic for total encoded blob size #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
changed the title
ian-shim
force-pushed
the
update-encoded-blob-size-accounting
branch
from
b243a84 to
9dcc124
Compare
ian-shim
force-pushed
the
update-encoded-blob-size-accounting
branch
from
9dcc124 to
8dfc912
Compare
jianoaix
reviewed
Apr 1, 2024
ian-shim
force-pushed
the
update-encoded-blob-size-accounting
branch
from
75d3770 to
95a5644
Compare
bxue-l2
reviewed
Apr 1, 2024
| for _, chunk := range b { | ||
| size += int64(chunk.Size()) | ||
| size += chunk.Size() |
There was a problem hiding this comment.
Just for your information, referring to yesterdays discussion, all chunk will now contains 32bytes. Nothing wrong here
| size += uint64(len(chunk.Coeffs) * 256) // 256 bytes per symbol | ||
| } | ||
| return size + 256*2 // + 256 * 2 bytes for proof | ||
| return result.Chunks.Size() |
There was a problem hiding this comment.
good catch, 256 byte is 8 times over
bxue-l2
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Bundle.Size()method to keep track of the total size of encoded blobsuint64instead ofint64Frame.Size()Checks