-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mainnet deploy #435
mainnet deploy #435
Conversation
function xtest() external { | ||
// get info on all the already-deployed contracts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make this call run()
instead of copying the code? is the require(deployer == tx.origin, ...)
check what's in the way right now?
I don't want to be too militant about code duplication but I find things to be much clearer + easier to review without copy-pasting 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM.
I don't think we're missing any config params, but am expecting we may need to make a late / post-deploy tweak or two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's still a good idea to regenerate bindings (even though none of the existing methods are affected)
wdyt?
agree |
Why are these changes needed?
Checks