Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainnet deploy #435

Merged
merged 21 commits into from
Apr 8, 2024
Merged

mainnet deploy #435

merged 21 commits into from
Apr 8, 2024

Conversation

0x0aa0
Copy link
Contributor

@0x0aa0 0x0aa0 commented Apr 2, 2024

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Comment on lines +234 to +235
function xtest() external {
// get info on all the already-deployed contracts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this call run() instead of copying the code? is the require(deployer == tx.origin, ...) check what's in the way right now?
I don't want to be too militant about code duplication but I find things to be much clearer + easier to review without copy-pasting 😄

Copy link

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.
I don't think we're missing any config params, but am expecting we may need to make a late / post-deploy tweak or two.

@0x0aa0 0x0aa0 marked this pull request as ready for review April 6, 2024 02:14
Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's still a good idea to regenerate bindings (even though none of the existing methods are affected)
wdyt?

@0x0aa0
Copy link
Contributor Author

0x0aa0 commented Apr 7, 2024

I think it's still a good idea to regenerate bindings (even though none of the existing methods are affected) wdyt?

agree

@0x0aa0 0x0aa0 merged commit b56aaf0 into master Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants