batcher allowlist #450
Merged
batcher allowlist #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-56
to
+57
| /// @notice address that is permissioned to confirm batches | ||
| address public batchConfirmer; | ||
| /// @notice mapping of addressed that are permissioned to confirm batches | ||
| mapping(address => bool) public isBatchConfirmer; |
There was a problem hiding this comment.
this is changing in the same storage slot. will this break testnet deployment when upgrading?
I guess when upgrading we can just:
- change the confirmer to the zero address
- upgrade
- set batch confirmer
Comment on lines
+133
to
+134
| isBatchConfirmer[_batchConfirmer] = !isBatchConfirmer[_batchConfirmer]; | ||
| emit BatchConfirmerStatusChanged(_batchConfirmer, isBatchConfirmer[_batchConfirmer]); |
There was a problem hiding this comment.
I'm not a huge fan of this pattern, but it's OK with me
ChaoticWalrus
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Approving this small change.
Adding test coverage for new behavior would be good, but I understand that's not the priority right now.
Noting this one storage slot change which may be relevant for testnet https://github.com/Layr-Labs/eigenda/pull/450/files#r1554183962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We need to allowlist a fallback batcher
Checks