Record the percent of stake held me each nonsigner #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will create a separate PR for setting the start and stop times for the query. |
ian-shim
reviewed
Apr 8, 2024
There was a problem hiding this comment.
lgtm, I think we can add a test in https://github.com/Layr-Labs/eigenda/blob/master/disperser/dataapi/server_test.go#L316
jianoaix
reviewed
Apr 9, 2024
| nonsignerMetric := OperatorNonsigningPercentageMetrics{ | ||
| OperatorId: fmt.Sprintf("0x%s", op), | ||
| OperatorAddress: nonsignerIdToAddress[op], | ||
| QuorumId: q, | ||
| TotalUnsignedBatches: unsignedCount, | ||
| TotalBatches: totalCount, | ||
| Percentage: pf, | ||
| StakePercentage: stakePercentage, |
There was a problem hiding this comment.
If this field is 0, it indicates the operator is no longer in the active set at block endBlock?
There was a problem hiding this comment.
Yes, that's the correct interpretation.
mooselumph
force-pushed
the
return-stake-w-nonsigners
branch
from
e0faf3e to
b435139
Compare
jianoaix
approved these changes
Apr 9, 2024
ian-shim
approved these changes
Apr 10, 2024
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Apr 11, 2024
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks