Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: byte data need to be base64 encoded #460

Closed
wants to merge 1 commit into from
Closed

Doc: byte data need to be base64 encoded #460

wants to merge 1 commit into from

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 8, 2024

Why are these changes needed?

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

bxue-l2
bxue-l2 reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@bxue-l2 bxue-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need this PR

@jianoaix jianoaix closed this Apr 8, 2024
@bxue-l2
Copy link
Contributor

bxue-l2 commented Apr 8, 2024

We noticed some issues to query disperser grpc endpoint using grpcul. The error states
Error invoking method "disperser.Disperser/DisperseBlob": error getting request data: illegal base64 data at input byte 0.

This issue happens only because grpcurl encodes "byte" in proto using base64 encoding. See this fullstorydev/grpcurl#141 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxue-l2 bxue-l2 bxue-l2 left review comments

@teddyknox teddyknox teddyknox approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianoaix @bxue-l2 @teddyknox