Query non-signers between start and stop times. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooselumph
commented
Apr 9, 2024
| @@ -645,12 +660,16 @@ const docTemplate = `{ | |||
| }, | |||
| "total_stake": { | |||
| "description": "deprecated: use TotalStakePerQuorum instead. Remove when the frontend is updated.", | |||
| "type": "integer" | |||
| "allOf": [ | |||
There was a problem hiding this comment.
I'm not sure what happened here. Perhaps I'm using a different version of swaggo?
jianoaix
reviewed
Apr 9, 2024
| @@ -465,7 +465,9 @@ func (s *server) FetchNonSigners(c *gin.Context) { | |||
| // @Summary Fetch operators non signing percentage | |||
| // @Tags Metrics | |||
| // @Produce json | |||
| // @Param interval query int false "Interval to query for operators nonsigning percentage [default: 3600]" | |||
| // @Param interval query int false "Interval to query for operators nonsigning percentage [default: 3600]" | |||
There was a problem hiding this comment.
It may be simpler to just have 2 params: endtime and interval. When endtime is missing, set it to time.Now(). Then it'll be also be backward compatible.
There was a problem hiding this comment.
That seems like a good suggestion. I'll go ahead and update.
jianoaix
approved these changes
Apr 10, 2024
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Apr 11, 2024
bxue-l2
pushed a commit
to bxue-l2/eigenda
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Allows for investigation of non-signer statistics over arbitrary intervals.
Checks