refactor the hex to OperatorID #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
approved these changes
Apr 15, 2024
core/assignment.go
Outdated
Comment on lines
41
to
49
| if len(s) != 64 && len(s) != 66 { | ||
| return OperatorID(opID), errors.New("operatorID hex string must be 64 or 66 bytes") | ||
| } | ||
| if len(s) == 66 { | ||
| if s[:2] != "0x" { | ||
| return OperatorID(opID), errors.New("operatorID hex string with 66 bytes must start with 0x") | ||
| } | ||
| s = s[2:] | ||
| } |
There was a problem hiding this comment.
nit:
s = strings.TrimPrefix(s, "0x")
s = strings.TrimPrefix(s, "0X")
if len(s) != 64 {
return OperatorID(opID), errors.New(...)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Refactor to reduce duplication
Checks