Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node] Add GRPC HealthCheck #497

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

siddimore
Copy link
Contributor

@siddimore siddimore commented Apr 18, 2024

Why are these changes needed?

Register HealthCheckServers for Dispersal and Retrieval, had this change done couple of weeks ago forgot to push it for review

This should enable via a grpc_client to query healthcheck on node as long as socketaddr is known

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@siddimore siddimore requested review from mooselumph and removed request for mooselumph April 18, 2024 20:19
@siddimore siddimore marked this pull request as ready for review April 18, 2024 20:20
@siddimore siddimore changed the title [Node] Add HealthCheck [Node] Add GRPC HealthCheck Apr 18, 2024
@siddimore siddimore merged commit da23ea7 into Layr-Labs:master Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants