Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient-unit-tests #50

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Conversation

mooselumph
Copy link
Collaborator

@mooselumph mooselumph commented Nov 17, 2023

Why are these changes needed?

  • Shares the localstack container across the unit tests within the repo.
  • Reuses the coverage profile in the github actions workflow.

The current CI failure is due to a permissions error on the wiki.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed if we report coverage right in the unit-tests flow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I can remove.

@mooselumph mooselumph merged commit 3c4c988 into Layr-Labs:master Nov 17, 2023
3 of 4 checks passed
@jianoaix jianoaix mentioned this pull request Nov 18, 2023
5 tasks
hopeyen pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants