Add operator registration metric at node #502
Conversation
| }, | ||
| []string{"quorum", "type"}, |
There was a problem hiding this comment.
wait I am very confused with this metrics.
This says Registered which seems, operator is registered or not. So binary 0 and 1
but we are setting this metrics to stake_share and rank. I think it will create confusion and probably not a right use of this?
There was a problem hiding this comment.
instead I think the better way can be - have 3 diff metrics
- stake_share and for that label would be
quorum - rank and for that label would be
quorum - registered for that label would be
quorum
so basically you just slice by quorum for all 3 metrics.
There was a problem hiding this comment.
It means the stake registered for each quorum: one for the precentage info, the other for the rank by the stake
I'm not sure why it's confusing
There was a problem hiding this comment.
coz the metrics name is registered so this means- we are emitting the value of registered. but here the value is actually of a label and that's confusing.
There was a problem hiding this comment.
like for example
node_eigenda_blobs_total{quorum="0",type="number"} 97605
node_eigenda_blobs_total{quorum="0",type="size"} 1.16567530656e+11
the metrics value is of node_eigenda_blobs_total - and then you can slice by quorum and type to identify more params.
There was a problem hiding this comment.
You just have 2 time series per quorum: the stake share and rank. The same for node_eigenda_blobs_total.
There is no confusion point, no inefficiency as well.
There was a problem hiding this comment.
from https://prometheus.io/docs/practices/naming/
Madhur makes good points and I feel it would be clearer if we move these labels into their own metrics time series.
There was a problem hiding this comment.
interesting, this may affect a lot of metrics we built
There was a problem hiding this comment.
yea I know. but I think we should at least start making sure new metrics are correct and eventually migrate other faulty ones.
There was a problem hiding this comment.
If you feel strongly about it, feel free to open a PR for it, I'll approve it
Why are these changes needed?
Provide metrics to help address major operator pain points
Checks