Read disperser allowlist from json file #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
allowlist-json-file
branch
from
861602b to
38e1915
Compare
dmanc
reviewed
Apr 20, 2024
| } | ||
| } | ||
|
|
||
| allowlist := parseAllowlistEntry(c) |
There was a problem hiding this comment.
This only reads the entries of the file once right? Don't you want to periodically check the file and update the parameters accordingly?
There was a problem hiding this comment.
I'll add that in a separate PR
dmanc
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Instead of configuring allowlist from cli flag, read from json file.
Checks