Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with onchain metrics collection interval #507

Closed
wants to merge 1 commit into from
Closed

Fix issue with onchain metrics collection interval #507

wants to merge 1 commit into from

Conversation

dmanc
Copy link
Contributor

@dmanc dmanc commented Apr 20, 2024

Why are these changes needed?

Currently it's collecting onchain metrics every 180 nanoseconds. Multiplying by time.Second gives the desired behavior.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@dmanc dmanc requested review from jianoaix and ian-shim April 20, 2024 02:00
@jianoaix
Copy link
Contributor

It's here already: #504

@dmanc
Copy link
Contributor Author

dmanc commented Apr 20, 2024

It's here already: #504

Sounds good, closing in favor of that one

@dmanc dmanc closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix Awaiting requested review from jianoaix

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmanc @jianoaix