Periodically reload allowlist from file #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
reviewed
Apr 26, 2024
| func (s *DispersalServer) LoadAllowlist() { | ||
| al, err := ReadAllowlistFromFile(s.rateConfig.AllowlistFile) | ||
| if err != nil { | ||
| s.logger.Error("failed to load allowlist", "err", err) |
There was a problem hiding this comment.
So if it fails to load allowlist, it will just keep the old values?
mooselumph
approved these changes
May 6, 2024
| s.logger.Error("failed to load allowlist", "err", err) | ||
| return | ||
| } | ||
| s.rateConfig.Allowlist = al |
There was a problem hiding this comment.
Does this need any locks?
There was a problem hiding this comment.
I don't think this really needs to be synchronized.
The worst case is that a potentially disallowed request goes through at the moment new allowlist is loaded (or vice versa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Deprecated
auth.allowlistand periodically reloads allowlist from the json file specified inauth.allowlist-fileauth.allowlistis no longer in useChecks