Removed unused parameters for improved code readability. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChengenH
commented
Apr 25, 2024
ChengenH
commented
- Removed unused parameters for improved code readability.
- Fix some incorrect punctuation.
ChengenH
commented
Apr 25, 2024
| @@ -28,7 +27,6 @@ func NewServer( | |||
| config *Config, | |||
| logger logging.Logger, | |||
| retrievalClient clients.RetrievalClient, | |||
| verifier encoding.Verifier, | |||
There was a problem hiding this comment.
This parameter has not been used and should be removed.
ChengenH
changed the title
|
pls check again |
ian-shim
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.