Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use POST instead of GET for ejection requests #530

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Use POST instead of GET for ejection requests #530

merged 1 commit into from
Apr 30, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 30, 2024 •
edited
Loading

Why are these changes needed?

Ejection request is to ask server to perform an action, so the appropriate method will be POST, not GET or PUT.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc and ian-shim and removed request for dmanc April 30, 2024 04:50
@jianoaix
Copy link
Contributor Author

Tested it work with curl -X POST ....

@jianoaix jianoaix merged commit fbba806 into Layr-Labs:master Apr 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

@dmanc dmanc dmanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jianoaix @dmanc @ian-shim