Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fireblocks API timeout to FireblocksConfig #534

Merged
merged 1 commit into from
May 1, 2024
Merged

Move fireblocks API timeout to FireblocksConfig #534

merged 1 commit into from
May 1, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented May 1, 2024

Why are these changes needed?

Putting Fireblocks API timeout config inside the Fireblocks config

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from mooselumph and jianoaix May 1, 2024 01:11
@ian-shim ian-shim marked this pull request as ready for review May 1, 2024 01:29
@ian-shim ian-shim merged commit 06f794b into Layr-Labs:master May 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @jianoaix