Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the fireblock flag #536

Merged
merged 1 commit into from
May 2, 2024
Merged

Clean up the fireblock flag #536

merged 1 commit into from
May 2, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented May 2, 2024

Why are these changes needed?

It will fail to buid/run dataapi server with duplicate flags

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from ian-shim May 2, 2024 00:15
@jianoaix jianoaix merged commit 7117d59 into Layr-Labs:master May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @ian-shim