Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log batch header hash hex #549

Merged
merged 1 commit into from
May 10, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented May 9, 2024

Why are these changes needed?

Minor update to log batch header hash as hex string instead of byte array for better legibility

Example output:

{"time":"2024-05-09T00:18:39.452095149Z","level":"INFO","source":{"function":"github.com/Layr-Labs/eigenda/core.(*StdSignatureAggregator).AggregateSignatures","file":"/home/runner/work/eigenda/eigenda/core/aggregation.go","line":176},"msg":"received signature from operator","component":"SignatureAggregator","operatorID":"3eb7d5df61c48ec2718d8c8ad52304effc970ae92f19138e032dae07b7c0d629","operatorAddress":"0xf270e0dd5a1cc34cda8fb991307604097e622002","socket":"localhost:32011;32012","quorumIDs":"[0]","batchHeaderHash":"6c4d83cbdf3a0bc2b85f4955368d80adb7fc0d432ae81a3368a81b4b4651e3e0"}

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested a review from jianoaix May 9, 2024 00:22
@ian-shim ian-shim marked this pull request as ready for review May 9, 2024 00:22
Copy link
Contributor

@jianoaix jianoaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can you take this chance to fix other places as well? e.g. a quick search pointing to

log.Error("Failed to delete the invalid batch that should be rolled back", "batchHeaderHash", batchHeaderHash, "err", deleteKeysErr)

@ian-shim ian-shim force-pushed the log-batcher-header-hash-hex branch from 8930b08 to 741f0e1 Compare May 9, 2024 16:52
@ian-shim ian-shim requested a review from jianoaix May 10, 2024 04:47
@ian-shim ian-shim merged commit cb55ffe into Layr-Labs:master May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants