Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node] Use URL builder to get reachability URL #575

Merged
merged 1 commit into from
May 22, 2024
Merged

[node] Use URL builder to get reachability URL #575

merged 1 commit into from
May 22, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented May 22, 2024 •
edited
Loading

Why are these changes needed?

Instead of using fmt.Sprintf, use net/url library to build the URL.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested a review from pschork May 22, 2024 00:46
@ian-shim ian-shim force-pushed the node-reachability-url branch from acab296 to a0cd8b9 Compare May 22, 2024 00:49
pschork
pschork approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@pschork pschork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@ian-shim ian-shim merged commit fa5866c into Layr-Labs:master May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschork pschork pschork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @pschork