Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use accountKey as AccountID #602

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Use accountKey as AccountID #602

merged 2 commits into from
Jun 14, 2024

Conversation

dmanc
Copy link
Contributor

@dmanc dmanc commented Jun 7, 2024

Why are these changes needed?

Breaking this PR into separate components #541. Want to get this in so I can add the secondary index on DynamoDB

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@dmanc dmanc requested review from ian-shim and mooselumph June 7, 2024 17:40
ian-shim
ian-shim approved these changes Jun 7, 2024
View reviewed changes
disperser/apiserver/server.go Show resolved Hide resolved
@dmanc dmanc merged commit 179b6aa into Layr-Labs:master Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmanc @ian-shim