Pull ejector out of dataapi
#608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Jun 19, 2024
| TransactionHash string `json:"transaction_hash"` | ||
| } | ||
|
|
||
| type NonSignerMetric struct { |
There was a problem hiding this comment.
breaking the import cycle
jianoaix
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
I remember this top-level folder operators was created exactly to host the ejector (in addition to churner). Now it's put in use.
dmanc
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This refactor pulls
ejectorout ofdataapiso it can be imported as a library.The existing ejection API behavior in
dataapishould remain the same.Checks