-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case-fold named and system colors #52
Conversation
That explains why |
Thank you! I've looked at a few of these, and it appears to be either a CSS syntax error (missing (semi)colons), which results in CSS properties being included in value tokens, or URLs containing For the latter, I just added code that strips URLs out of the value before colors are matched. That seems to fix a lot of the false positives. But not sure how to proceed with the syntax errors. Since the problem occurs only with |
The bug almost makes for an interesting side note in the analysis about the buggy/unpredictable ways CSS is written, which makes me inclined to leave it. Happy to rerun with your latest changes and take it from there. |
Yeah, I think we should not case fold system colors, and only match them when written with capitalization, which is how I've seen them used anyway. |
I've updated the sheet with case sensitive system colors. Background usage drops to 0.00%. |
Prevent duplicate named colors like RED, red, Red, etc. Normalize all system colors to the casing in the source array.
Progress on #32