Remove FrameCount in favor of Bevy counterpart #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
requested changes
Aug 22, 2024
|
@alice-i-cecile I don't see a |
|
Also, thanks for jumping in to help out! Sorry for the random burst of noise from my end! |
|
Ah sorry, I meant RELEASES.md! And no worries at all; it's very welcome. |
|
OK -- I added a section for v0.6 and included release notes for this PR and #37 since I didn't follow suit there |
alice-i-cecile
approved these changes
Aug 22, 2024
|
Awesome. Ping me on Discord when you think that we're ready for the release of 0.6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #29 - Use built-in frame count
Changes
FrameCountwith bevy counterpart in all placesFrameCountbehavior -- this crate'sFrameCountwas updated inFirstrather thanLastNotes
Previous
FrameCountimplementation usessaturating_add/sub operations, but based on the documentation forFrameCount, it seems thatwrapping_would be more appropriate. I changed any+operators to usewrapping_functions to be specific for now.Also, let me know if I have removed any intended effects of the playback tests. I tried to reflect the original intent to the best of my ability.