Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deleteActivityProfile): Restructuring #719

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ryasmi
Copy link
Member

@ryasmi ryasmi commented Dec 13, 2020

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2020

This pull request fixes 1 alert when merging 7897229 into 22803df - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2021

This pull request fixes 1 alert when merging 26d8e30 into 47f7548 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2021

This pull request fixes 1 alert when merging a4b0216 into 47f7548 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #719 (a4b0216) into master (47f7548) will decrease coverage by 1.39%.
The diff coverage is 71.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   99.23%   97.83%   -1.40%     
==========================================
  Files         602      631      +29     
  Lines        6235     6559     +324     
  Branches      456      494      +38     
==========================================
+ Hits         6187     6417     +230     
- Misses         11       88      +77     
- Partials       37       54      +17     
Impacted Files Coverage Δ
...ActivityProfile/tests/utils/assertOutsideClient.ts 100.00% <ø> (ø)
...rofile/utils/getClient/getClientRecordFromMongo.ts 20.00% <20.00%> (ø)
...ns/deleteActivityProfile/utils/translateWarning.ts 43.47% <43.47%> (ø)
...eleteActivityProfile/utils/createExpressHandler.ts 58.97% <58.97%> (ø)
...tivityProfile/utils/getAuthConfig/getAuthConfig.ts 66.66% <66.66%> (ø)
...ctivityProfile/utils/getClient/trackClientUsage.ts 71.42% <71.42%> (ø)
.../deleteActivityProfile/utils/handleErrorViaHttp.ts 71.87% <71.87%> (ø)
...file/utils/getClient/getClientRecordFromTesters.ts 73.33% <73.33%> (ø)
...ActivityProfile/utils/getClient/getClientRecord.ts 75.00% <75.00%> (ø)
...deleteActivityProfile/utils/getClient/getClient.ts 80.00% <80.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f7548...a4b0216. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant