BC2A-1408: Remove duplicate apdu_parser #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 1st definition in SDK - 2nd definition in the Application (same filename also) - Fix dependencies (header files, definitions)
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
1 task
lpascal-ledger
previously approved these changes
Nov 17, 2023
xchapron-ledger
previously approved these changes
Nov 17, 2023
cedelavergne-ledger
dismissed stale reviews from xchapron-ledger and lpascal-ledger
via
f93ac1a
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
2 times, most recently
from
8ed0275 to
3c6d24f
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1408_conflict-name
branch
from
3c6d24f to
944e9b6
Compare
lpascal-ledger
approved these changes
Nov 20, 2023
lemois-1337
pushed a commit
to lemois-1337/app-karlsen
that referenced
this pull request
Oct 2, 2024
Implement Kaspa address generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
apdu_parserwas duplicated between the App itself and the SDK. This PR allows to clean up the code:This PR also updates the version (and thus the corresponding tests results and screenshots)