Bugfix LIVE 11903 fix btc sign message hex (#6642)

* fix: btc signmessage return hex * fix: changeset * fix: btc signmessage unit test
LedgerHQ · Apr 12, 2024 · 0db1bf8 · 0db1bf8
1 parent fca871f
commit 0db1bf8
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/.changeset/lovely-doors-rest.md b/.changeset/lovely-doors-rest.md
@@ -0,0 +1,5 @@
+---
+"@ledgerhq/coin-bitcoin": minor
+---
+
+fix bitcoin signmessage return from base64 to hex
diff --git a/libs/coin-modules/coin-bitcoin/src/hw-signMessage.test.ts b/libs/coin-modules/coin-bitcoin/src/hw-signMessage.test.ts
@@ -12,8 +12,8 @@ describe("signMessage", () => {
       getWalletPublicKey: jest.fn(),
       signMessage: jest.fn().mockResolvedValue({
         v: 1,
-        r: "RRRRRSSSSSRRRRRSSSSS",
-        s: "SSSSSRRRRRSSSSSRRRRR",
+        r: "407c9da9dadf23a2d7e863f51aa3512fe3c86619f1d57b16e5d0659155e83888",
+        s: "207c9da9dadf736839484733637aba12fe3c86619f1d57b16e5d0659155e8388",
       }),
       splitTransaction: jest.fn(),
       createPaymentTransaction: jest.fn(),
@@ -34,10 +34,11 @@ describe("signMessage", () => {
     expect(signature).toEqual({
       rsv: {
         v: 1,
-        r: "RRRRRSSSSSRRRRRSSSSS",
-        s: "SSSSSRRRRRSSSSSRRRRR",
+        r: "407c9da9dadf23a2d7e863f51aa3512fe3c86619f1d57b16e5d0659155e83888",
+        s: "207c9da9dadf736839484733637aba12fe3c86619f1d57b16e5d0659155e8388",
       },
-      signature: "IA==",
+      signature:
+        "20407c9da9dadf23a2d7e863f51aa3512fe3c86619f1d57b16e5d0659155e83888207c9da9dadf736839484733637aba12fe3c86619f1d57b16e5d0659155e8388",
     });
   });
 });

diff --git a/libs/coin-modules/coin-bitcoin/src/hw-signMessage.ts b/libs/coin-modules/coin-bitcoin/src/hw-signMessage.ts
@@ -13,9 +13,7 @@ export const signMessage =
       signer.signMessage(account.freshAddressPath, hexMessage),
     )) as BitcoinSignature;
     const v = result["v"] + 27 + 4;
-    const signature = Buffer.from(`${v.toString(16)}${result["r"]}${result["s"]}`, "hex").toString(
-      "base64",
-    );
+    const signature = `${v.toString(16)}${result["r"]}${result["s"]}`;
     return {
       rsv: result,
       signature,