Skip to content

Commit

Permalink
test: fix missing catalog v2 test id
Browse files Browse the repository at this point in the history
  • Loading branch information
abdurrahman-ledger committed Jul 3, 2024
1 parent 09a4063 commit 2e11ef5
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const Container = styled(Tabbable).attrs<{
flexDirection: "column",
alignItems: "center",
fontSize: 4,
})<{ id?: string }>`
})`
min-height: 180px;
padding: 24px;
border-radius: 4px;
Expand Down Expand Up @@ -61,7 +61,7 @@ export function AppCard({ manifest, onClick, id }: Props) {
}, [onClick, isDisabled]);

return (
<Container id={id} onClick={handleClick} disabled={isDisabled}>
<Container data-test-id={id} onClick={handleClick} disabled={isDisabled}>
<AppDetails manifest={manifest} />
</Container>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,13 @@ export function FullCard(props: PropsCard<LiveAppManifest>) {
);

return (
<Container highlighted={highlighted} disabled={disabled} onClick={onClick} flex={1}>
<Container
data-test-id={`platform-catalog-app-${manifest.id}`}
highlighted={highlighted}
disabled={disabled}
onClick={onClick}
flex={1}
>
<Flex alignItems="center">
<Logo icon={manifest.icon} name={manifest.name} size="medium" disabled={disabled} />

Expand Down
2 changes: 1 addition & 1 deletion apps/ledger-live-desktop/tests/page/discover.page.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { AppPage } from "tests/page/abstractClasses";

export class DiscoverPage extends AppPage {
private testAppCatalogItem = this.page.locator("#platform-catalog-app-dummy-live-app");
private testAppCatalogItem = this.page.getByTestId("platform-catalog-app-dummy-live-app");
private disclaimerTitle = this.page.getByTestId("live-app-disclaimer-drawer-title");

async openTestApp() {
Expand Down

0 comments on commit 2e11ef5

Please sign in to comment.