Skip to content

Commit

Permalink
fix: improve wording on Stax
Browse files Browse the repository at this point in the history
  • Loading branch information
KVNLS committed Sep 26, 2023
1 parent 77b363e commit 2f9a6c0
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 49 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ const OnboardingAppInstallStep = ({ device, deviceToRestore, onComplete, onError
: t("onboardingAppInstall.default.title", { productName })}
</Text>
<Text variant="paragraphLineHeight" color="neutral.c70" textAlign="center" mt={2}>
{t(`onboardingAppInstall.${deviceToRestore ? "restore" : "default"}.subtitle`)}
{t(`onboardingAppInstall.${deviceToRestore ? "restore" : "default"}.subtitle`, {
productName,
})}
</Text>
<Flex pt={8} pb={2} justifyContent="space-between">
<Button
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ const SoftwareCheckContent = ({
<Button variant="main" size="small" outline={false} onClick={onClickViewUpdate}>
{updateSkippable
? t("syncOnboarding.manual.softwareCheckContent.firmwareUpdate.resumeUpdateCTA")
: t("syncOnboarding.manual.softwareCheckContent.firmwareUpdate.viewUpdateCTA")}
: t("syncOnboarding.manual.softwareCheckContent.firmwareUpdate.viewUpdateCTA", {
modelName,
})}
</Button>
{updateSkippable ? (
<Button
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const SeedStep = ({ seedPathStatus, deviceModelId }: Props) => {
</Flex>
) : seedPathStatus === "restore_seed" ? (
<>
<StepText>{t("syncOnboarding.manual.seedContent.restoreSeed", { productName })}</StepText>
<StepText>{t("syncOnboarding.manual.seedContent.restoreSeed")}</StepText>
<ContinueOnDeviceWithAnim
deviceModelId={deviceModelId}
text={t("syncOnboarding.manual.seedContent.followInstructions", { productName })}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const Disclaimer = ({ firmware, onContinue, t }: Props) => (
>
<Flex flex={1} />
<Button data-test-id="modal-continue-button" variant="main" onClick={onContinue}>
{t("common.continue")}
{t("manager.firmware.installUpdate")}
</Button>
</Flex>
</Flex>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const Body = ({
)}

<Text ff="Inter|Regular" textAlign="center" color="palette.text.shade100">
{t("manager.modal.confirmIdentifierText", { productName: deviceModel.productName })}
{t("manager.modal.confirmIdentifierText")}
</Text>
</>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { useHistory } from "react-router-dom";
import TrackPage from "~/renderer/analytics/TrackPage";
import Track from "~/renderer/analytics/Track";
import Box from "~/renderer/components/Box";
import Text from "~/renderer/components/Text";
import ErrorDisplay from "~/renderer/components/ErrorDisplay";
import { StepProps } from "../";
import { context } from "~/renderer/drawers/Provider";
Expand All @@ -27,11 +26,8 @@ const Title = styled(Box).attrs(() => ({
font-weight: 500;
`;

const StepConfirmation = ({
error,
appsToBeReinstalled,
finalStepSuccessDescription,
}: StepProps) => {
const StepConfirmation = ({ error, deviceModelId }: StepProps) => {
const device = getDeviceModel(deviceModelId);
const { t } = useTranslation();

useEffect(() => () => log("firmware-record-end"), []);
Expand All @@ -56,16 +52,9 @@ const StepConfirmation = ({
size={64}
iconSize={24}
/>
<Title mt={9}>{t("manager.modal.successTitle")}</Title>
<Box mt={2} mb={5}>
<Text ff="Inter|Regular" fontSize={4} color="palette.text.shade80" textAlign="center">
{finalStepSuccessDescription
? finalStepSuccessDescription
: appsToBeReinstalled
? t("manager.modal.successTextApps")
: t("manager.modal.successTextNoApps")}
</Text>
</Box>
<Title mt={9}>
{t("manager.modal.successTitle", { deviceName: device ? device.productName : "" })}
</Title>
<Box mx={7} />
</Container>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ const ChangeDeviceLanguagePromptDrawer: React.FC<Props> = ({
deviceName,
})}
descriptionWording={t("deviceLocalization.changeDeviceLanguagePrompt.description", {
language: t(
`deviceLocalization.languages.${Languages[currentLanguage].deviceSupport?.label}`,
),
deviceName,
})}
/>
)}
Expand Down
48 changes: 23 additions & 25 deletions apps/ledger-live-desktop/static/i18n/en/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -1168,7 +1168,7 @@
"seedContent": {
"title": "Secret Recovery Phrase",
"recoverSeed": "Placeholder: Recover",
"restoreSeed": "Make sure to use a Secret Recovery Phrase generated by a Ledger for the guaranted security of your assets.\n\nDon't have one? Use your {{productName}} to generate a new Phrase.",
"restoreSeed": "Make sure to use a Secret Recovery Phrase generated by a Ledger device for maximum security over your assets.",
"selection": "Choose the setup option that best suits you:",
"selectionNewLedger": "“Set up as a new Ledger” lets you create a new wallet. This generates a new Secret Recovery Phrase.",
"selectionRestore": "“Restore” lets you restore access to your existing assets with your Secret Recovery Phrase, or by using Ledger Recover.",
Expand All @@ -1179,7 +1179,6 @@
"newSeedDescription4": "The only place you should enter your Secret Recovery Phrase is on your Ledger device.",
"newSeedDescription5": "Do not share it. Do not lose it.",
"newSeedContinueOnDevice": "View and write down the Secret Recovery Phrase generated on your {{productName}}",
"recovery": "Make sure to use a Secret Recovery Phrase generated by a Ledger for the guaranted security of your assets.\n\nDon't have one? Use your {{productName}} to generate a new Phrase.",
"restoreChoiceContinueOnDevice": "Select relevant option on your {{productName}}",
"restoreChoiceSRPTitle": "Restore using Secret Recovery Phrase",
"restoreChoiceSRPDescription": "Use a Secret Recovery Phrase generated by a Ledger device for maximum security.",
Expand All @@ -1199,13 +1198,13 @@
"resumeCheckCTA": "Resume checks"
},
"genuineCheckErrorDrawer": {
"quitSetupCTA": "Quit setup",
"quitSetupCTA": "Cancel set up",
"goToSettingsCTA": "Go to settings",
"retryCTA": "Retry",
"contactSupportCTA": "Contact Ledger support",
"notFoundEntityError": {
"title": "We could not check if this device was genuine.",
"description": "The experimental setting “My Ledger provider ({{providerNumber}})” may be conflicting with the genuine check. You can disable it in settings."
"title": "Initiate Genuine Check again",
"description": "You must first disable “My Ledger Provider ({{providerNumber}})” setting. To disable it, open Ledger Live “Settings”, select “Experimental features”, and then toggle off “Manager provider”."
},
"deviceNotGenuineError": {
"title": "This {{productName}} is not genuine",
Expand All @@ -1223,7 +1222,7 @@
},
"subtitle": {
"active": "This makes sure your {{modelName}} is an official Ledger.",
"cancelled": "You cannot setup your {{modelName}} without allowing this check"
"cancelled": "This Check is mandatory to continue setting up your {{modelName}} using the Ledger Live app."
},
"resumeCTA": "Resume Genuine Gheck"
},
Expand All @@ -1234,13 +1233,13 @@
"updateAvailable": "OS update {{firmwareVersion}} is available"
},
"subtitle": {
"active": "This checks if your {{modelName}} Operatin System is up to date or not.",
"updateAvailable": "We recommend performing this update to have access to the latest security features"
"active": "This checks if your {{modelName}} Operating System is up to date or not.",
"updateAvailable": "Update for optimal security and access to the latest features."
},
"viewUpdateCTA": "View update",
"viewUpdateCTA": "Update {{modelName}} OS",
"resumeUpdateCTA": "Resume update",
"skipUpdateCTA": "Skip update",
"retryUpdateCTA": "Retry",
"retryUpdateCTA": "Try again",
"finalStepSuccessDescription": "Back to OS check",
"finalStepSuccessButtonLabel": "Continue"
}
Expand Down Expand Up @@ -1273,7 +1272,7 @@
"closeButton": "Close"
},
"desyncOverlay": {
"errorMessage": "It looks like connection to your {{deviceName}} was lost. We're trying to reconnect."
"errorMessage": "Connection with {{deviceName}} lost. Trying to reconnect."
},
"header": {
"helpButton": "Need help?"
Expand Down Expand Up @@ -1874,8 +1873,9 @@
"dontHaveSeed": "Don't have your recovery phrase? ",
"followTheGuide": "Follow our step by step update guide",
"removeApps": "Uninstall all apps before updating",
"update": "Update {{productName}}",
"update": "{{productName} OS update",
"updateBtn": "Update firmware",
"installUpdate": "Install update",
"banner": {
"warning": "Update Firmware to {{latestFirmware}} is available",
"cta": "Go to My Ledger",
Expand All @@ -1888,7 +1888,7 @@
"latest": "Firmware version {{version}} is available",
"contactSupport": "Contact support",
"deprecated": "Device firmware version too old to be updated. Contact Ledger Support for a replacement.",
"prepareSeed": "Ensure your 24-word recovery phrase is written down on the Recovery sheet and it is available, as a precaution.",
"prepareSeed": "Ensure your 24-word Recovery Phrase is written down on the Recovery sheet and it is available, as a precaution.",
"disclaimerTitle": "You are about to install <1>firmware version {{version}}</1>."
},
"modal": {
Expand All @@ -1911,7 +1911,7 @@
"flash": "Preparing your device..."
},
"confirmIdentifier": "Verify the identifier",
"confirmIdentifierText": "Confirm install on {{productName}}",
"confirmIdentifierText": "Tap on “Install” to start the OS update",
"identifier": "Identifier",
"newFirmware": "New firmware {{version}}",
"confirmUpdate": "Please confirm the update on your device",
Expand All @@ -1922,9 +1922,7 @@
"mcuSecondNanoX": "Press and hold the left button until <1><0>{{bootloaderOption}}</0></1> appears. Press both buttons to confirm and reconnect your device.",
"mcuBlueFirst": "Press and hold the side button for 10 seconds to turn off the device. Release the button.",
"mcuBlueSecond": "Press and hold the button for at least 5 seconds until the Boot Options are displayed. Tap Bootloader Mode",
"successTitle": "OS update success.",
"successTextApps": "Please re-install the apps on your device",
"successTextNoApps": "You can now install apps on your device",
"successTitle": "Your {{deviceName}} OS is up to date.",
"sucessCTAApps": "Reinstall apps",
"SuccessCTANoApps": "Install apps",
"cancelReinstallCTA": "Install update",
Expand Down Expand Up @@ -2241,13 +2239,13 @@
},
"deviceLocalization": {
"language": "Language",
"deviceLanguage": "Change device language",
"changeLanguage": "Change",
"deviceLanguage": "Change Device Language",
"changeLanguage": "Change language",
"dontChangeLanguage": "Don't change",
"changeDeviceLanguage": "Change your device language?",
"changeDeviceLanguagePrompt": {
"title": "{{language}} is also available for your {{deviceName}}",
"description": "Would you like to change its language to {{language}}?"
"title": "Change language on {{deviceName}} to {{language}}?",
"description": "Use your {{deviceName}} and the Ledger Live app in the same language?"
},
"firmwareUpdatePrompt": {
"title": "Set your {{deviceName}} in {{language}}?",
Expand Down Expand Up @@ -4276,7 +4274,7 @@
}
},
"selectDevice": {
"title": "Select your device",
"title": "What's your Ledger?",
"selectLabel": "Select"
},
"selectUseCase": {
Expand Down Expand Up @@ -5884,9 +5882,9 @@
"skipCTA": "I'll do this later"
},
"default": {
"title": "{{ productName }} uses apps to enable secure blockchain transactions",
"subtitle": "We recommend downloading a default set of apps. You can download more later.",
"installCTA": "Install applications",
"title": "{{ productName }} has it own apps. You need them to transact.",
"subtitle": "As an example, the Bitcoin app for {{productName}} is required to sign Bitcoin transactions.\nInstall default apps to get your {{productName}} transaction-ready.",
"installCTA": "Install now",
"skipCTA": "I'll do this later"
},
"progress": {
Expand Down

0 comments on commit 2f9a6c0

Please sign in to comment.