feat: update manifest id for multibuy to v2 (#4648)

LedgerHQ · Sep 11, 2023 · 8b09b0b · 8b09b0b · vercel · Sep 11, 2023
1 parent 34e7f6f
commit 8b09b0b
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/.changeset/quick-students-glow.md b/.changeset/quick-students-glow.md
@@ -0,0 +1,7 @@
+---
+"ledger-live-desktop": patch
+"live-mobile": patch
+"@ledgerhq/live-common": patch
+---
+
+Update multibuy manifest to v2 to ensure full backwards compatibility
diff --git a/apps/ledger-live-desktop/tests/specs/services/buy.spec.ts b/apps/ledger-live-desktop/tests/specs/services/buy.spec.ts
@@ -22,7 +22,7 @@ test.beforeAll(async () => {
   // Check that dummy app in libs/test-utils/dummy-ptx-app has been started successfully
   testServerIsRunning = await LiveAppWebview.startLiveApp("dummy-ptx-app/public", {
     name: "Buy App",
-    id: "multibuy",
+    id: "multibuy-v2",
     permissions: [
       {
         method: "account.request",

diff --git a/apps/ledger-live-mobile/src/components/RootNavigator/ExchangeLiveAppNavigator.tsx b/apps/ledger-live-mobile/src/components/RootNavigator/ExchangeLiveAppNavigator.tsx
@@ -2,6 +2,7 @@ import React, { useMemo } from "react";
 import { createStackNavigator } from "@react-navigation/stack";
 import { useTheme } from "styled-components/native";
 import { findCryptoCurrencyByKeyword } from "@ledgerhq/live-common/currencies/index";
+import { DEFAULT_MULTIBUY_APP_ID } from "@ledgerhq/live-common/wallet-api/constants";
 import { ScreenName } from "../../const";
 import { getStackNavigatorConfig } from "../../navigation/navigatorConfig";
 
@@ -28,7 +29,7 @@ const ExchangeBuy = (
           goToURL: _props.route.params?.goToURL,
           lastScreen: _props.route.params?.lastScreen,
           mode: "buy",
-          platform: _props.route.params?.platform || "multibuy",
+          platform: _props.route.params?.platform || DEFAULT_MULTIBUY_APP_ID,
           referrer: _props.route.params?.referrer,
         },
       }}
@@ -52,7 +53,7 @@ const ExchangeSell = (
           goToURL: _props.route.params?.goToURL,
           lastScreen: _props.route.params?.lastScreen,
           mode: "sell",
-          platform: _props.route.params?.platform || "multibuy",
+          platform: _props.route.params?.platform || DEFAULT_MULTIBUY_APP_ID,
           referrer: _props.route.params?.referrer,
         },
       }}

diff --git a/apps/ledger-live-mobile/src/navigation/DeeplinksProvider.tsx b/apps/ledger-live-mobile/src/navigation/DeeplinksProvider.tsx
@@ -5,6 +5,8 @@ import SplashScreen from "react-native-splash-screen";
 import { getStateFromPath, LinkingOptions, NavigationContainer } from "@react-navigation/native";
 import { useFlipper } from "@react-navigation/devtools";
 import { useRemoteLiveAppContext } from "@ledgerhq/live-common/platform/providers/RemoteLiveAppProvider/index";
+import { DEFAULT_MULTIBUY_APP_ID } from "@ledgerhq/live-common/wallet-api/constants";
+
 import Braze from "react-native-appboy-sdk";
 import { LiveAppManifest } from "@ledgerhq/live-common/platform/types";
 import useFeature from "@ledgerhq/live-common/featureFlags/useFeature";
@@ -76,7 +78,7 @@ function getProxyURL(url: string) {
   // This is to handle links set in the useFromAmountStatusMessage in LLC.
   // Also handles a difference in paths between LLD on LLD /platform/:app_id
   // but on LLM /discover/:app_id
-  if (hostname === "platform" && ["multibuy"].includes(platform)) {
+  if (hostname === "platform" && [DEFAULT_MULTIBUY_APP_ID].includes(platform)) {
     return url.replace("://platform", "://discover");
   }
 

diff --git a/libs/ledger-live-common/src/wallet-api/constants.ts b/libs/ledger-live-common/src/wallet-api/constants.ts
@@ -24,6 +24,6 @@ export const DISCOVER_STORE_KEY = "discover";
 
 export const DISCOVER_INITIAL_CATEGORY = "all";
 
-export const DEFAULT_MULTIBUY_APP_ID = "multibuy";
+export const DEFAULT_MULTIBUY_APP_ID = "multibuy-v2";
 
 export const INTERNAL_APP_IDS = [DEFAULT_MULTIBUY_APP_ID];