[LIVE-5135] Migrate Ethereum family implementation to EVM family #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
🦋 Changeset detectedLatest commit: 533b0b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
desktop
chabroA
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
github-actions
bot
added
ledgerjs
3 tasks
chabroA
force-pushed
the
feat/live-5135-merge-ethereum-in-evm-family
branch
from
98d350b to
15d6b16
Compare
chabroA
changed the title
3 tasks
chabroA
force-pushed
the
feat/live-5135-merge-ethereum-in-evm-family
branch
from
0cae97c to
7028960
Compare
disable rounding for estimated fees on LLD tx confirm screen otherwise the fees are not similar between what is shown on LLD and on the nano device, because the value is not rounded on the nano device
Avoid duplication between legacy and EIP1559 tx type by using describe.each and reorder tests cases to improve readability
Fixup of ef171ec that originally introduced this change
BOT_FILTER_FAMILIES is always defined in this line since we check it in the line just above
Since ethereum familly does not exist anymore
Now filters on a select list of currencies (the ones previously tested by the ethereum specs) instead of the whole evm familly
remove the use for hardcoded currencies unit in minBalancePerCurrencyId. Use the unit defined in currency config instead. More reliable and future-proof
… coin-evm/logic Remove duplication of MessageProperties type definition and getMessageProperties function definition between LLD and LLM Since only evm currencies seem to use getMessageProperties as of today, it has been moved to coin-evm
chabroA
force-pushed
the
feat/live-5135-merge-ethereum-in-evm-family
branch
from
c7dc091 to
533b0b3
Compare
lvndry
added a commit
that referenced
this pull request
Sep 14, 2023
Co-authored-by: lvndry <[email protected]> Co-authored-by: Alexandre Chabrolin <[email protected]> Co-authored-by: Landry Monga <[email protected]>
ghost
restored the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR removes the
ethereumfamily from the Ledger Live codebase and use thecoin-evmimplementation instead.General overview of changes:
ethereumfamily from the Ledger Live codebaseevmfamily components on LLD to match what was present inethereumfamily featurewiseevmfamily components on LLM to match what was present inethereumfamily featurewiseevminstead ofethereumwallet-apiandlive-app-sdkto useevmfamily instead ofethereum📝 List of all related PRs (including merged and draft ones) to easily keeps track of whet's ongoing on that topic:
📝 Notes on bot results 🤖:
cf.:
#4285 (comment)
#4285 (comment)
#4285 (comment)
#4285 (comment)
Ropsten is deprecated and should be removed after the merge by this https://ledgerhq.atlassian.net/browse/LIVE-8906
The explorer used originally, seems to have been discontinued, and replaced by a mintscan one (cf. https://docs.evmos.org/develop/block-explorers#list-of-block-explorers). Evmos should therefore be removed from the evm currencies as it should be supported by the cosmos framework instead with the ethermint update.
The explorer used originally, seems to have been discontinued, and replaced by a routescan one (https://explorer.metis.io/documentation) (cf. https://ledgerhq.atlassian.net/browse/LIVE-9338)
Same thing as with Metis, the explorer used originally, seems to have been discontinued, and replaced by a routescan one (https://bobascan.com/documentation) (cf. https://ledgerhq.atlassian.net/browse/LIVE-9338)
related to
telos_evm, also happens on develop (cf. this and this)TODO:
❓ Context
LLDLLMLLCcoin-evm✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.