Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to RXJS 7 [WIP] #4522

Closed
wants to merge 2 commits into from
Closed

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Aug 29, 2023

📝 Description

To match with wallet-api using RXJS, we bumped it's version to 7

I used some documentation to help me out

I've only fixed the broken toPromise using lastValueFrom as the api changed for toPromise (can now return undefined), but the api is deprecated and we should replace them.

Studies

Things to note:

  • drop rxjs-compat and make sure it works with v6
  • fix breaking changes from v5 to v6
  • update to v7

Things to watch out for:

  • toPromise() signature change (can now return underfined)
    • will be deprecated in future version => lastValueFrom and firstValueFrom
  • throwError signature change

❓ Context

  • Impacted projects: libs, lld, llm, cli
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • [] No breaking changes this is to be tested still

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ledger-live-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 4:26pm
live-common-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 4:26pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 4:26pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 4:26pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 4:26pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

⚠️ No Changeset found

Latest commit: 0e1c3e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant