[feat] Vechain integration #4947

hedi-edelbloute · 2023-10-06T07:33:45Z

📝 Description

VeChain integration

❓ Context

Impacted projects: LLC,LLD,LLM
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-6240

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

…rebased feat: vet and vethor integration

- added options to cli-transaction file and changed the property name to vechainCurrency - buildOptimisticOperation now uses only data already calculated - removed mode property from vechain transaction, added estimatedFees to provide the data to the previous point - added basic vechain app unit test

The query was failing resulting in an incorrect gas calculation

vercel · 2023-11-15T10:05:34Z

Deployment failed with the following error:

Too many requests - try again in 2 minutes (more than 60, code: "api-deployments-flood").

live-github-bot · 2023-11-15T10:30:25Z

Desktop Build Checks

⚠️ renderer bundle size significantly increased: 31.9mb -> 32mb. Please check if this is expected.
⚠️ hash.js library is now duplicated in and renderer (regression)
⚠️ scrypt-js library is now duplicated in and renderer (regression)

live-github-bot · 2023-11-15T17:49:45Z

Desktop Build Checks

⚠️ renderer bundle size significantly increased: 31.9mb -> 32mb. Please check if this is expected.
⚠️ hash.js library is now duplicated in and renderer (regression)
⚠️ scrypt-js library is now duplicated in and renderer (regression)
⚠️ @noble/hashes/ripemd160 library is now duplicated in and renderer (regression)

live-github-bot · 2023-11-16T09:18:55Z

Desktop Build Checks

⚠️ renderer bundle size significantly increased: 31.9mb -> 32.1mb. Please check if this is expected.
⚠️ hash.js library is now duplicated in and renderer (regression)
⚠️ scrypt-js library is now duplicated in and renderer (regression)
⚠️ @noble/hashes/ripemd160 library is now duplicated in and renderer (regression)

live-github-bot · 2023-11-16T09:41:13Z

Desktop Build Checks

⚠️ renderer bundle size significantly increased: 31.9mb -> 32mb. Please check if this is expected.
⚠️ hash.js library is now duplicated in and renderer (regression)
⚠️ scrypt-js library is now duplicated in and renderer (regression)
⚠️ @noble/hashes/ripemd160 library is now duplicated in and renderer (regression)

live-github-bot · 2023-11-16T10:13:29Z

Desktop Build Checks

⚠️ renderer bundle size significantly increased: 31.9mb -> 32.1mb. Please check if this is expected.
⚠️ hash.js library is now duplicated in renderer (regression)
⚠️ scrypt-js library is now duplicated in renderer (regression)

live-github-bot · 2023-11-16T13:59:34Z

Desktop Build Checks

Comparing 7d81ed4 against e7b5ffc.

⚠️ renderer bundle size significantly increased: 31.9mb -> 32mb. Please check if this is expected.
⚠️ hash.js library is now duplicated in renderer (regression)
⚠️ scrypt-js library is now duplicated in renderer (regression)

ghost

🚀

github-actions · 2023-11-16T15:20:03Z

[Bot] Testing with 'Nitrogen' ❌ 1 txs 💰 1 miss funds ($0.38) ⏲ 17.2s

❌ 1 specs have problems: VeChain VTHO
💰 1 specs may miss funds: VeChain VET

What is the bot and how does it work? Everything is documented here!

❌ 1 mutation errors

necessary accounts resynced in 0.27ms
▬ VeChain 1.1.1 on nanoX 2.2.2
→ FROM Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain 0 VET spendable. 
  TokenAccount Vethor: 54.3706899375 VTHO (2 ops) (! sum of ops 55 VTHO)
max spendable ~0
★ using mutation 'move all VTHO'
→ TO Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
✔️ transaction SEND MAX TO 0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD
STATUS (1830ms)
  amount: 53.8542299375 VTHO
  estimated fees: 0.51646 VET
  total spent: 54.3706899375 VTHO
errors: 
errors: 
⚠️ VechainAppPleaseEnableContractDataAndMultiClause: Please enable contract data in Vechain app settings
(totally spent 1853ms – ends at 2023-11-16T15:20:02.788Z)

⚠️ 2 spec hints

Spec VeChain VTHO:
- mutations should define a testDestination(): move all VTHO
Spec VeChain VET:
- No mutation were found possible. Yet there are funds in the accounts, please investigate.

Details of the 1 mutations

Spec VeChain VTHO (3)

Spec VeChain VTHO found 3 Vechain accounts. Will use VeChain 1.1.1 on nanoX 2.2.2
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
necessary accounts resynced in 0.27ms
▬ VeChain 1.1.1 on nanoX 2.2.2
→ FROM Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain 0 VET spendable. 
  TokenAccount Vethor: 54.3706899375 VTHO (2 ops) (! sum of ops 55 VTHO)
max spendable ~0
★ using mutation 'move all VTHO'
→ TO Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
✔️ transaction SEND MAX TO 0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD
STATUS (1830ms)
  amount: 53.8542299375 VTHO
  estimated fees: 0.51646 VET
  total spent: 54.3706899375 VTHO
errors: 
errors: 
⚠️ VechainAppPleaseEnableContractDataAndMultiClause: Please enable contract data in Vechain app settings
(totally spent 1853ms – ends at 2023-11-16T15:20:02.792Z)

Spec VeChain VET (3)

Spec VeChain VET found 3 Vechain accounts. Will use VeChain 1.1.1 on nanoX 2.2.2
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain

Details of the 3 uncovered mutations

Spec VeChain VTHO (1)

move ~50% VTHO: Vechain: VTHO balance is not enough (2)

Spec VeChain VET (2)

move ~50% VET: Vechain: VET balance is empty (2), Vechain: VTHO balance is not enough (1)
move all VET: Vechain: VET balance is empty (2), Vechain: VTHO balance is not enough (1)

Portfolio ($0.38) – Details of the 2 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
VeChain VTHO (3)	7 ops , 5 VET ($0.19)	⚠️ 12	`0xc4B17901FECf86932c3bb296BB00E7c6816Fd416`
VeChain VET (3)	7 ops , 5 VET ($0.19)	⚠️ 12	`0xc4B17901FECf86932c3bb296BB00E7c6816Fd416`

Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain
Vechain 1 cross: 0 VET (4ops) (0xc4B17901FECf86932c3bb296BB00E7c6816Fd416 on 44'/818'/0'/0/0) vechain#0 js:2:vechain:0xc4B17901FECf86932c3bb296BB00E7c6816Fd416:vechain
Vechain 2: 5 VET (3ops) (0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD on 44'/818'/0'/0/1) vechain#1 js:2:vechain:0x7850ddc6a26AF0C078b9f1569Ca16746B2ACd3bD:vechain
Vechain 3: 0 VET (0ops) (0x6fc5998724338CDe55Bba798273FAdcDE79c5074 on 44'/818'/0'/0/2) vechain#2 js:2:vechain:0x6fc5998724338CDe55Bba798273FAdcDE79c5074:vechain

Performance ⏲ 17.2s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	2.28ms	15.2s	11ms	1830ms	N/A	N/A	N/A	N/A
VeChain VTHO (2)	0.33ms	7.7s	1.84ms	1830ms	N/A	N/A	N/A	N/A
VeChain VET (2)	1.96ms	7.5s	9ms	N/A	N/A	N/A	N/A	N/A

What is the bot and how does it work? Everything is documented here!

davidecarpini and others added 30 commits March 7, 2023 10:29

feat: vet and vethor integration

41afb53

Merge pull request #4 from vechainfoundation/dev/vechain-integration-…

9ff4f89

…rebased feat: vet and vethor integration

fix(libs): fix block height

043b338

fix(libs): fix error message when vtho not enough

4dde433

fix(mobile): hide vtho chart

1e35039

remove TODO

38d31ac

fix(ledger-live-desktop): add empty graph for VTHO

36901a3

fix(libs): fix pending operations

ac7039f

fix(ledger-live-desktop): create custom warning component

dd50e34

fix(libs): fix to gas calculation

ad4f3e5

fix(account-units): add ethereum units to vechain account

7e71e8a

fix(libs): fix naming conventions

eee791a

add(hw): add test for vet application

3f25e4c

fix(hw): add coverage for hw-app

ff2a53f

fix(hw): fix dependencies

41332fa

Fixing estimateGas function

d3ff6d7

The query was failing resulting in an incorrect gas calculation

fix(mobile): fix i18n

f612e19

fix(web): fix i18n

24c46fc

fix(web): fix warning banner

e9579a7

fix(desktop): fix to color and message warning banner

36a4bd0

fix(libs): fix for bot tests

8ff15db

Merge remote-tracking branch 'upstream/develop' into dev/develop-rebase

e2ed3f0

fix(libs/lld): fix to desktop graphs + minor fixes

73823de

fix(libs): add vtho fees

b07dc93

change token type

bf3a2ed

fix: mobile vechain fees

5d353e5

fix(libs): correct max VTHO amount sendable

349f84a

fix to fees for operations

0b5fb20

fix to id for token operations

adc4534

edit token id

e0a6d5e

vercel bot deployed to Preview – web-tools November 15, 2023 16:37 View deployment

hedi-edelbloute added 2 commits November 15, 2023 17:37

fix type error

5e14ab9

Merge branch 'develop' into feat/vechain

3245efc

vercel bot deployed to Preview – web-tools November 15, 2023 17:32 View deployment

fix unit test

ff94c6c

vercel bot deployed to Preview – web-tools November 16, 2023 08:18 View deployment

update snapshots

f6b9727

vercel bot deployed to Preview – web-tools November 16, 2023 08:24 View deployment

update snapshot'

6fb14a6

vercel bot deployed to Preview – web-tools November 16, 2023 09:00 View deployment

fix integ test

1d3a3e3

vercel bot deployed to Preview – web-tools November 16, 2023 09:23 View deployment

update token id

5da7218

vercel bot deployed to Preview – web-tools November 16, 2023 09:52 View deployment

fix integ tests

7d81ed4

vercel bot deployed to Preview – web-tools November 16, 2023 13:40 View deployment

ghost approved these changes Nov 16, 2023

View reviewed changes

hedi-edelbloute merged commit 2edfa53 into develop Nov 16, 2023
50 of 51 checks passed

hedi-edelbloute deleted the feat/vechain branch November 16, 2023 16:09

lvndry pushed a commit that referenced this pull request Nov 16, 2023

[feat] Vechain integration (#4947)

0c059f8

lvndry pushed a commit that referenced this pull request Nov 16, 2023

[feat] Vechain integration (#4947)

915e522

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] Vechain integration #4947

[feat] Vechain integration #4947

hedi-edelbloute commented Oct 6, 2023 •

edited

Loading

vercel bot commented Nov 15, 2023

live-github-bot bot commented Nov 15, 2023

live-github-bot bot commented Nov 15, 2023

live-github-bot bot commented Nov 16, 2023

live-github-bot bot commented Nov 16, 2023

live-github-bot bot commented Nov 16, 2023

live-github-bot bot commented Nov 16, 2023

ghost left a comment

github-actions bot commented Nov 16, 2023

Spec VeChain VTHO (3)

Spec VeChain VET (3)

Spec VeChain VTHO (1)

Spec VeChain VET (2)

[feat] Vechain integration #4947

[feat] Vechain integration #4947

Conversation

hedi-edelbloute commented Oct 6, 2023 • edited Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Nov 15, 2023

live-github-bot bot commented Nov 15, 2023

Desktop Build Checks

live-github-bot bot commented Nov 15, 2023

Desktop Build Checks

live-github-bot bot commented Nov 16, 2023

Desktop Build Checks

live-github-bot bot commented Nov 16, 2023

Desktop Build Checks

live-github-bot bot commented Nov 16, 2023

Desktop Build Checks

live-github-bot bot commented Nov 16, 2023

Desktop Build Checks

ghost left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 16, 2023

[Bot] Testing with 'Nitrogen' ❌ 1 txs 💰 1 miss funds ($0.38) ⏲ 17.2s

Spec VeChain VTHO (3)

Spec VeChain VET (3)

Spec VeChain VTHO (1)

Spec VeChain VET (2)

hedi-edelbloute commented Oct 6, 2023 •

edited

Loading