Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[support] Update polkadot dependencies #5112

Merged
merged 23 commits into from
Nov 23, 2023

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Oct 18, 2023

📝 Description

Update @polkadot/* dependencies

❓ Context

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screenshot 2023-11-21 at 14 59 19

Simulator Screenshot - iPhone 13 - 2023-11-21 at 15 08 50

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@lvndry lvndry self-assigned this Oct 18, 2023
@lvndry lvndry requested a review from a team as a code owner October 18, 2023 08:44
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: 36ce824

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 2:11pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 2:11pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 2:11pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 2:11pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2023 2:11pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Oct 18, 2023
@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch from 82a7d6f to a69b1fe Compare October 18, 2023 12:07
@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch from a69b1fe to 1cef61b Compare October 19, 2023 08:20
@ghost
Copy link

ghost commented Oct 19, 2023

(replacing #4739 to attempt to pass CI)

@ghost ghost changed the title update @polkdadot/* dependencies [support] Update polkadot dependencies Oct 19, 2023
@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch from 1cef61b to a7ce893 Compare October 19, 2023 14:35
@gre
Copy link
Contributor

gre commented Oct 19, 2023

i tested a build locally, and your PR don't pass the test because

Screenshot 2023-10-19 at 17 13 54

@gre
Copy link
Contributor

gre commented Oct 19, 2023

tip for next time if you reach timeout issue on CI = they usually mean the app never loads / fails to load.

you can download the results from the CI

Screenshot 2023-10-19 at 17 17 08

you extract one and you can check both the html report and the videos

Screenshot 2023-10-19 at 17 17 24

Screenshot 2023-10-19 at 17 17 51

from the video we see the problem

Screenshot 2023-10-19 at 17 17 57

@ghost
Copy link

ghost commented Oct 19, 2023

@lvndry I know that you tested builds before, and I still don't see a link between the error and the changes... please see if you reproduce by testing builds now, but there's something weird here.

@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch from a7ce893 to f46c729 Compare October 19, 2023 16:31
@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch 7 times, most recently from 0780e51 to 36ce824 Compare November 9, 2023 09:40
Copy link

vercel bot commented Nov 9, 2023

Deployment failed with the following error:

Too many requests - try again in 50 seconds (more than 60, code: "api-deployments-flood").

Copy link

vercel bot commented Nov 9, 2023

Deployment failed with the following error:

Too many requests - try again in 49 seconds (more than 60, code: "api-deployments-flood").

@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch 4 times, most recently from 5198a5d to 3197add Compare November 13, 2023 13:38
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the bundle size script is showing improvement & things finally deduplicated 🚀

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvndry For changes with visual impact you can provide before/after screenshots, to illustrate the change and prove that it was tested 👍

@lvndry lvndry force-pushed the feat/live-8984-update-polkdatot-dependencies branch from bfdadae to 8d1176e Compare November 21, 2023 14:10
Copy link

[Bot] Testing with 'Nitrogen' ✅ 1 txs ($26.42) ⏲ 2min 28s

✅ 1 specs are successful: Polkadot

What is the bot and how does it work? Everything is documented here!

Details of the 1 mutations

Spec Polkadot (14)

Spec Polkadot found 14 Polkadot accounts (preload: 2544ms). Will use Polkadot 24.9430.3 on nanoSP 1.1.0
Polkadot 1 cross: 1.5138 DOT (47ops) (14X7Au3YQTURKHkEQi3vsvJqZM6ZLEEJnLBQH4HwW69x12dW on 44'/354'/0'/0'/0') polkadotbip44#0 js:2:polkadot:14X7Au3YQTURKHkEQi3vsvJqZM6ZLEEJnLBQH4HwW69x12dW:polkadotbip44
Polkadot 2: 1.1273 DOT (36ops) (14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36 on 44'/354'/1'/0'/0') polkadotbip44#1 js:2:polkadot:14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36:polkadotbip44
Polkadot 3: 0 DOT (25ops) (15oo7XFweTU6d7N3pq3rUznGxvidut87TwpGJHZxbQ2ayCB4 on 44'/354'/2'/0'/0') polkadotbip44#2 js:2:polkadot:15oo7XFweTU6d7N3pq3rUznGxvidut87TwpGJHZxbQ2ayCB4:polkadotbip44
Polkadot 4: 0 DOT (29ops) (1oXomFZKEfULDXuMUFjob18pLJjax8pAsXfK9jaUx5MBqgN on 44'/354'/3'/0'/0') polkadotbip44#3 js:2:polkadot:1oXomFZKEfULDXuMUFjob18pLJjax8pAsXfK9jaUx5MBqgN:polkadotbip44
Polkadot 5: 1.14807 DOT (30ops) (14wi7BRNSDYwr3vnZmpzFmTD2wH4Xq2oUKrELmYRWiXYVpf7 on 44'/354'/4'/0'/0') polkadotbip44#4 js:2:polkadot:14wi7BRNSDYwr3vnZmpzFmTD2wH4Xq2oUKrELmYRWiXYVpf7:polkadotbip44
Polkadot 6: 0 DOT (13ops) (14yhMxSNxjEy8mMKaPK3wHZycNQjt4G6w9x9fCUXCqQkErQK on 44'/354'/5'/0'/0') polkadotbip44#5 js:2:polkadot:14yhMxSNxjEy8mMKaPK3wHZycNQjt4G6w9x9fCUXCqQkErQK:polkadotbip44
Polkadot 7: 0 DOT (8ops) (15qXcTKgVfY8xzFLJSajdyFiEkxtMQEoetQzNDUoECJKFuwH on 44'/354'/6'/0'/0') polkadotbip44#6 js:2:polkadot:15qXcTKgVfY8xzFLJSajdyFiEkxtMQEoetQzNDUoECJKFuwH:polkadotbip44
Polkadot 8: 0 DOT (16ops) (16XuPbdDwqgJEvekFqDga44LF5HDMH9JcVntR5VhooixviDg on 44'/354'/7'/0'/0') polkadotbip44#7 js:2:polkadot:16XuPbdDwqgJEvekFqDga44LF5HDMH9JcVntR5VhooixviDg:polkadotbip44
Polkadot 9: 0 DOT (7ops) (15hSJZ8RQDyBTDanm5sA1tfTiFmG8cXGsF7HCZcMgveezvjH on 44'/354'/8'/0'/0') polkadotbip44#8 js:2:polkadot:15hSJZ8RQDyBTDanm5sA1tfTiFmG8cXGsF7HCZcMgveezvjH:polkadotbip44
Polkadot 10: 1.32017 DOT (25ops) (1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B on 44'/354'/9'/0'/0') polkadotbip44#9 js:2:polkadot:1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B:polkadotbip44
Polkadot 11 cross: 0 DOT (4ops) (15Cd4kYoq7b61wzhNF6maBiSMEmE8vEJD2uhxNc5cR8DuvnM on 44'/354'/10'/0'/0') polkadotbip44#10 js:2:polkadot:15Cd4kYoq7b61wzhNF6maBiSMEmE8vEJD2uhxNc5cR8DuvnM:polkadotbip44
Polkadot 12: 0 DOT (7ops) (13wjwHrmHoLP9rCWuE7r2Qk29Q7taTbTL1jdUGasHjCyGv5s on 44'/354'/11'/0'/0') polkadotbip44#11 js:2:polkadot:13wjwHrmHoLP9rCWuE7r2Qk29Q7taTbTL1jdUGasHjCyGv5s:polkadotbip44
Polkadot 13: 0 DOT (2ops) (125Zq6JfjcYXap4uARFn8yWK683uaLeobqUiohg4qgFjfuQC on 44'/354'/12'/0'/0') polkadotbip44#12 js:2:polkadot:125Zq6JfjcYXap4uARFn8yWK683uaLeobqUiohg4qgFjfuQC:polkadotbip44
Polkadot 14: 0 DOT (0ops) (12PHsDoZwvq9u2VJA3CT3eyk44h58vfS2YzWZcecRv6nPdDC on 44'/354'/13'/0'/0') polkadotbip44#13 js:2:polkadot:12PHsDoZwvq9u2VJA3CT3eyk44h58vfS2YzWZcecRv6nPdDC:polkadotbip44
necessary accounts resynced in 0.36ms
▬ Polkadot 24.9430.3 on nanoSP 1.1.0
→ FROM Polkadot 10: 1.32017 DOT (25ops) (1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B on 44'/354'/9'/0'/0') polkadotbip44#9 js:2:polkadot:1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B:polkadotbip44 1.3201766236 DOT spendable. 

max spendable ~1.30443
★ using mutation 'send 50%~'
→ TO Polkadot 2: 1.1273 DOT (36ops) (14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36 on 44'/354'/1'/0'/0') polkadotbip44#1 js:2:polkadot:14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36:polkadotbip44
✔️ transaction 
SEND  0.1593219 DOT
TO 14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36
STATUS (405ms)
  amount: 0.1593219 DOT
  estimated fees: 0.0156348041 DOT
  total spent: 0.1749567041 DOT
errors: 
errors: 
✔️ has been signed! (7.8s) 
✔️ broadcasted! (183ms) optimistic operation: 
  -0.1749567041 DOT  OUT        0xa459259993179f0a73b5cc5784f64fe6963632d8f5f940ce35e87dfeca06a726 2023-11-23T05:38
✔️ operation confirmed (30.6s): 
  -0.1749567041 DOT  OUT        0xa459259993179f0a73b5cc5784f64fe6963632d8f5f940ce35e87dfeca06a726 2023-11-23T05:38
✔️ Polkadot 10: 1.14521 DOT (26ops) (1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B on 44'/354'/9'/0'/0') polkadotbip44#9 js:2:polkadot:1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B:polkadotbip44 1.1452199195 DOT spendable. 
(in 30.6s)
✔️ destination operation 
  +0.1593219 DOT     IN         0xa459259993179f0a73b5cc5784f64fe6963632d8f5f940ce35e87dfeca06a726 2023-11-23T05:38
(in 10.7s)


Details of the 6 uncovered mutations

Spec Polkadot (6)

  • send max: send is too low to activate account (3), balance is too low (10)
  • bond - bondExtra: not enough balance to bond (3), balance is too low (10)
  • unbond: can't unbond (3), balance is too low (10)
  • rebond: can't rebond (3), balance is too low (10)
  • nominate: can't nominate (3), balance is too low (10)
  • withdraw: nothing to withdraw (3), balance is too low (10)
Portfolio ($26.42) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
Polkadot (14) 251 ops (+2), 5.10935 DOT ($26.42) ⚠️ 25 14X7Au3YQTURKHkEQi3vsvJqZM6ZLEEJnLBQH4HwW69x12dW
Polkadot 1 cross: 1.5138 DOT (47ops) (14X7Au3YQTURKHkEQi3vsvJqZM6ZLEEJnLBQH4HwW69x12dW on 44'/354'/0'/0'/0') polkadotbip44#0 js:2:polkadot:14X7Au3YQTURKHkEQi3vsvJqZM6ZLEEJnLBQH4HwW69x12dW:polkadotbip44
Polkadot 2: 1.28662 DOT (37ops) (14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36 on 44'/354'/1'/0'/0') polkadotbip44#1 js:2:polkadot:14sRADm72v7aWADe8fidpf6WiXS8AAwJHvYhAiB1risDWK36:polkadotbip44
Polkadot 3: 0 DOT (25ops) (15oo7XFweTU6d7N3pq3rUznGxvidut87TwpGJHZxbQ2ayCB4 on 44'/354'/2'/0'/0') polkadotbip44#2 js:2:polkadot:15oo7XFweTU6d7N3pq3rUznGxvidut87TwpGJHZxbQ2ayCB4:polkadotbip44
Polkadot 4: 0 DOT (29ops) (1oXomFZKEfULDXuMUFjob18pLJjax8pAsXfK9jaUx5MBqgN on 44'/354'/3'/0'/0') polkadotbip44#3 js:2:polkadot:1oXomFZKEfULDXuMUFjob18pLJjax8pAsXfK9jaUx5MBqgN:polkadotbip44
Polkadot 5: 1.14807 DOT (30ops) (14wi7BRNSDYwr3vnZmpzFmTD2wH4Xq2oUKrELmYRWiXYVpf7 on 44'/354'/4'/0'/0') polkadotbip44#4 js:2:polkadot:14wi7BRNSDYwr3vnZmpzFmTD2wH4Xq2oUKrELmYRWiXYVpf7:polkadotbip44
Polkadot 6: 0 DOT (13ops) (14yhMxSNxjEy8mMKaPK3wHZycNQjt4G6w9x9fCUXCqQkErQK on 44'/354'/5'/0'/0') polkadotbip44#5 js:2:polkadot:14yhMxSNxjEy8mMKaPK3wHZycNQjt4G6w9x9fCUXCqQkErQK:polkadotbip44
Polkadot 7: 0 DOT (8ops) (15qXcTKgVfY8xzFLJSajdyFiEkxtMQEoetQzNDUoECJKFuwH on 44'/354'/6'/0'/0') polkadotbip44#6 js:2:polkadot:15qXcTKgVfY8xzFLJSajdyFiEkxtMQEoetQzNDUoECJKFuwH:polkadotbip44
Polkadot 8: 0 DOT (16ops) (16XuPbdDwqgJEvekFqDga44LF5HDMH9JcVntR5VhooixviDg on 44'/354'/7'/0'/0') polkadotbip44#7 js:2:polkadot:16XuPbdDwqgJEvekFqDga44LF5HDMH9JcVntR5VhooixviDg:polkadotbip44
Polkadot 9: 0 DOT (7ops) (15hSJZ8RQDyBTDanm5sA1tfTiFmG8cXGsF7HCZcMgveezvjH on 44'/354'/8'/0'/0') polkadotbip44#8 js:2:polkadot:15hSJZ8RQDyBTDanm5sA1tfTiFmG8cXGsF7HCZcMgveezvjH:polkadotbip44
Polkadot 10: 1.14521 DOT (26ops) (1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B on 44'/354'/9'/0'/0') polkadotbip44#9 js:2:polkadot:1AgX2tJoNJPhKucxiRYUW2YJWeGLbHjBfZkQxFYugbfV44B:polkadotbip44
Polkadot 11 cross: 0 DOT (4ops) (15Cd4kYoq7b61wzhNF6maBiSMEmE8vEJD2uhxNc5cR8DuvnM on 44'/354'/10'/0'/0') polkadotbip44#10 js:2:polkadot:15Cd4kYoq7b61wzhNF6maBiSMEmE8vEJD2uhxNc5cR8DuvnM:polkadotbip44
Polkadot 12: 0 DOT (7ops) (13wjwHrmHoLP9rCWuE7r2Qk29Q7taTbTL1jdUGasHjCyGv5s on 44'/354'/11'/0'/0') polkadotbip44#11 js:2:polkadot:13wjwHrmHoLP9rCWuE7r2Qk29Q7taTbTL1jdUGasHjCyGv5s:polkadotbip44
Polkadot 13: 0 DOT (2ops) (125Zq6JfjcYXap4uARFn8yWK683uaLeobqUiohg4qgFjfuQC on 44'/354'/12'/0'/0') polkadotbip44#12 js:2:polkadot:125Zq6JfjcYXap4uARFn8yWK683uaLeobqUiohg4qgFjfuQC:polkadotbip44
Polkadot 14: 0 DOT (0ops) (12PHsDoZwvq9u2VJA3CT3eyk44h58vfS2YzWZcecRv6nPdDC on 44'/354'/13'/0'/0') polkadotbip44#13 js:2:polkadot:12PHsDoZwvq9u2VJA3CT3eyk44h58vfS2YzWZcecRv6nPdDC:polkadotbip44
Performance ⏲ 2min 28s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 2544ms 84.7s 26ms 405ms 7.8s 183ms 30.6s 10.7s
Polkadot (13) 2544ms 84.7s 26ms 405ms 7.8s 183ms 30.6s 10.7s

What is the bot and how does it work? Everything is documented here!

@lvndry lvndry merged commit ab1db96 into develop Nov 23, 2023
47 of 48 checks passed
@lvndry lvndry deleted the feat/live-8984-update-polkdatot-dependencies branch November 23, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants