Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-8424] After the ESC is successful, when tapping the button “Continue to setup”, there’s a 1-second delay #5150

Closed
wants to merge 2 commits into from

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Oct 20, 2023

📝 Description

Pending state of ESC CTA

❓ Context

  • Impacted projects: LLM
  • Linked resource(s): LIVE-8424

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

live-8424.mov

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@live-github-bot
Copy link
Contributor

@jdabbech-ledger

Unfortunately this PR does not comply with the Contributing Conventions and will be closed automatically.

Feel free to reopen this PR once you have browsed through the guidelines.


Found Issues:

  • the branch name develop is invalid

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

⚠️ No Changeset found

Latest commit: b676745

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@live-github-bot live-github-bot bot closed this Oct 20, 2023
@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 20, 2023 8:05am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 20, 2023 8:05am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 20, 2023 8:05am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 20, 2023 8:05am
web-tools ⬜️ Ignored (Inspect) Oct 20, 2023 8:05am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants