Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evm fee drawer correcly updates tx after changing fee strat (aligned with BTC) #7755

Closed
wants to merge 1 commit into from

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Sep 5, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

BTC does this

bridge.updateTransaction(transaction, {
feePerByte: amount,
feesStrategy,
}),
);
},

Imo it is better than prepareTransaction again after and refetch gasValues

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner September 5, 2024 08:57
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 5, 2024 8:57am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2024 8:57am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 5, 2024 8:57am
web-tools ⬜️ Ignored (Inspect) Sep 5, 2024 8:57am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 5, 2024
@CremaFR
Copy link
Member Author

CremaFR commented Sep 5, 2024

closing. transactions should be prepared after each update.

@CremaFR CremaFR closed this Sep 5, 2024
@CremaFR CremaFR deleted the fix/LIVE-13912 branch September 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant