Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LIVE-13955): put back params forgotten to live app #7766

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

lpaquet-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

In demo 3 params were moved an 2 were forgotten. Putting them back

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-13955


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lpaquet-ledger lpaquet-ledger requested a review from a team as a code owner September 6, 2024 07:36
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 6, 2024 7:36am
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 6, 2024 7:36am
native-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2024 7:36am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 6, 2024 7:36am
web-tools ⬜️ Ignored (Inspect) Sep 6, 2024 7:36am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 6, 2024
@lpaquet-ledger lpaquet-ledger merged commit 77f9a5e into develop Sep 9, 2024
34 of 35 checks passed
@lpaquet-ledger lpaquet-ledger deleted the fix/LIVE-13955 branch September 9, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants