Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angle logos #7770

Merged
merged 3 commits into from
Sep 6, 2024
Merged

angle logos #7770

merged 3 commits into from
Sep 6, 2024

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented Sep 6, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

New angle tokens svgs.

LLM

SCR-20240906-ourt SCR-20240906-ourt SCR-20240906-oujm

LLD

SCR-20240906-ourt SCR-20240906-oujm SCR-20240906-oujm

Note that one of the provided svgs had a class attribute that was breaking the crypto-ui build, changed from class to inlined style

before

    <style>
      .cls-1 {
        fill: #76a0fc;
        fill-rule: evenodd;
        stroke-width: 0px;
      }
    </style>
  </defs>
  <path class="cls-1" d="m3.33,13.04l4.21,4.25,4.32-4.36s.03,0,.04-.02c0,0,0-.01.01-.02s.01,0,.02,0c.01,0,.02-.02.04-.02s.02.01.04.02c0,0,.01,0,.02,0,0,0,0,.01.01.02.01,0,.03,0,.04.02l4.32,4.36,4.21-4.25L11.97,4.33,3.33,13.04Z"/>
  <polygon class="cls-1" points="3.82 13.95 4.72 15.53 7.87 18.71 7.42 17.59 3.82 13.95"/>
  <polygon class="cls-1" points="12.12 15.56 15.6 19.08 16.22 17.54 12.12 13.41 12.12 15.56"/>
  <path class="cls-1" d="m12,0C5.37,0,0,5.37,0,12s5.37,12,12,12,12-5.37,12-12S18.62,0,12,0Zm8.95,13.11l-1.4 
...

now

  <path style="fill:#76a0fc;fill-rule:evenodd;stroke-width:0px" d="m3.33,13.04l4.21,4.25,4.32-4.36s.03,0,.04-.02c0,0,0-.01.01-.02s.01,0,.02,0c.01,0,.02-.02.04-.02s.02.01.04.02c0,0,.01,0,.02,0,0,0,0,.01.01.02.01,0,.03,0,.04.02l4.32,4.36,4.21-4.25L11.97,4.33,3.33,13.04Z"/>
  <polygon style="fill:#76a0fc;fill-rule:evenodd;stroke-width:0px" points="3.82 13.95 4.72 15.53 7.87 18.71 7.42 17.59 3.82 13.95"/>
  <polygon style="fill:#76a0fc;fill-rule:evenodd;stroke-width:0px" points="12.12 15.56 15.6 19.08 16.22 17.54 12.12 13.41 12.12 15.56"/>
  <path style="fill:#76a0fc;fill-rule:evenodd;stroke-width:0px" d="m12,0C5.37,0,0,5.37,0,12s5.37,12,12,12,12-5.37,12-12S18.62,0,12,0Zm8.95,13.11l-1.47,2.58s-.01.02-.02.03l-3.69,3.72s-.04.02-.06.03c0,0-.01.01-.02.02,0,0,0,0,0,0-.04,0-.07,0-.1-.02,0,0,0,0,0-.01,0,0,0,0-.01,0l-3.58-3.61-3.58,3.61s0,0-.01,0c0,0,0,0,0,.01-.03.02-.07.03-.1.02,0,0,0,0,0,0,0,0-.01-.01-.02-.02-.02,0-.04-.01-.06-.03l-3.69-3.72s-.02-.02-.02-.03l-1.47-2.58s0-.03,0-.04c0-.02,0-.03,0-.04,0-.02.01-.04.02-.06,0-.01,0-.02.01-.03L11.86,4.01s.07-.04.11-.04.08.02.11.04l8.85,8.93s0,.02.01.03c.01.02.02.04.02.06,0,.02,0,.03,0,.04,0,.01,0,.03,0,.04Z"/>

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 6, 2024 2:53pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 2:53pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 2:53pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 2:53pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 2:53pm

@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Sep 6, 2024
@Wozacosta Wozacosta merged commit 3de65c8 into develop Sep 6, 2024
57 of 69 checks passed
@Wozacosta Wozacosta deleted the chore/angle-logos-13820 branch September 6, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants