Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove errors in drawer #7776

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: remove errors in drawer #7776

merged 1 commit into from
Sep 9, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Sep 9, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

I introduced a regression when refactoring errors for swap. This PR aims to remove the regression and clean up the code

Video of the issue. Warning error that open buy BTC if clicked (new regression)

Screen.Recording.2024-09-09.at.11.36.49.mov

Video of the fix. Old behavior. No warning

Screen.Recording.2024-09-09.at.11.37.45.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner September 9, 2024 09:40
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 9, 2024 9:40am
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 9, 2024 9:40am
native-ui-storybook ⬜️ Ignored (Inspect) Sep 9, 2024 9:40am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 9, 2024 9:40am
web-tools ⬜️ Ignored (Inspect) Sep 9, 2024 9:40am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 9, 2024
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@CremaFR CremaFR merged commit 3eafc83 into develop Sep 9, 2024
37 checks passed
@CremaFR CremaFR deleted the fix/btcfeedrawerreg branch September 9, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants